Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add X-Trino-Extra-Credential header and remove user override #3246

Merged
merged 2 commits into from
Sep 24, 2022
Merged

fix: Add X-Trino-Extra-Credential header and remove user override #3246

merged 2 commits into from
Sep 24, 2022

Conversation

ammarar
Copy link
Contributor

@ammarar ammarar commented Sep 23, 2022

What this PR does / why we need it: Adds more authentication properties to users of Trino

Which issue(s) this PR fixes:

Fixes #

@felixwang9817
Copy link
Collaborator

felixwang9817 commented Sep 24, 2022 •
edited
Loading

hey @ammarar thanks for your PR! your changes look good to me - I'm happy to stamp once you sign your commit and format your PR title correctly (it should be something like fix: PR Title, you can see other PRs for examples)

@felixwang9817 felixwang9817 self-assigned this Sep 24, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 24, 2022 •
edited
Loading

Codecov Report

Base: 67.50% // Head: 76.64% // Increases project coverage by +9.14% 🎉

Coverage data is based on head (dae2b2f) compared to base (b48d36b).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3246      +/-   ##
==========================================
+ Coverage   67.50%   76.64%   +9.14%     
==========================================
  Files         179      216      +37     
  Lines       16371    18198    +1827     
==========================================
+ Hits        11051    13948    +2897     
+ Misses       5320     4250    -1070
Flag Coverage Δ
integrationtests 67.30% <ø> (-0.20%) ⬇️
unittests 58.14% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tores/contrib/trino_offline_store/trino_queries.py 14.58% <0.00%> (ø)
...stores/contrib/trino_offline_store/trino_source.py 5.37% <ø> (ø)
...on/feast/infra/materialization/snowflake_engine.py 93.18% <0.00%> (-0.41%) ⬇️
...tion/contrib/spark/spark_materialization_engine.py 71.84% <0.00%> (-0.28%) ⬇️
...offline_stores/contrib/spark_repo_configuration.py 100.00% <0.00%> (ø)
...ores/contrib/trino_offline_store/tests/__init__.py 100.00% <0.00%> (ø)
...tion/feature_repos/universal/online_store/hbase.py 50.00% <0.00%> (ø)
...thon/feast/infra/utils/postgres/postgres_config.py 100.00% <0.00%> (ø)
...s/contrib/mssql_offline_store/tests/data_source.py 46.93% <0.00%> (ø)
...ine_stores/contrib/cassandra_repo_configuration.py 100.00% <0.00%> (ø)
... and 104 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ammarar ammarar changed the title add extra creds and remove user override Fix: Add X-Trino-Extra-Credential header and remove user override Sep 24, 2022
@ammarar
do changes with signing
3293c85 
Signed-off-by: ammarar <ammar.alrashed@gmail.com>
@felixwang9817 felixwang9817 changed the title Fix: Add X-Trino-Extra-Credential header and remove user override fix: Add X-Trino-Extra-Credential header and remove user override Sep 24, 2022
felixwang9817
felixwang9817 approved these changes Sep 24, 2022
View reviewed changes
Copy link
Collaborator

@felixwang9817 felixwang9817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ammarar, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@felixwang9817
Copy link
Collaborator

thanks for fixing @ammarar, just stamped your PR!

@ammarar
lint fix
dae2b2f 
Signed-off-by: ammarar <ammar.alrashed@gmail.com>
@felixwang9817
Copy link
Collaborator

/lgtm

@feast-ci-bot feast-ci-bot merged commit 164e666 into feast-dev:master Sep 24, 2022
adchia pushed a commit that referenced this pull request Sep 26, 2022
@ammarar @adchia
fix: Add X-Trino-Extra-Credential header and remove user override (#…
f38506c 
…3246)

* do changes with signing

Signed-off-by: ammarar <ammar.alrashed@gmail.com>

* lint fix

Signed-off-by: ammarar <ammar.alrashed@gmail.com>

Signed-off-by: ammarar <ammar.alrashed@gmail.com>
felixwang9817 pushed a commit to felixwang9817/feast that referenced this pull request Sep 26, 2022
@ammarar @felixwang9817
fix: Add X-Trino-Extra-Credential header and remove user override (f…
5ecaa22 
…east-dev#3246)

* do changes with signing

Signed-off-by: ammarar <ammar.alrashed@gmail.com>

* lint fix

Signed-off-by: ammarar <ammar.alrashed@gmail.com>

Signed-off-by: ammarar <ammar.alrashed@gmail.com>
vmallya-123 pushed a commit to vmallya-123/feast that referenced this pull request Sep 27, 2022
@ammarar @vmallya-123
fix: Add X-Trino-Extra-Credential header and remove user override (f…
0728463 
…east-dev#3246)

* do changes with signing

Signed-off-by: ammarar <ammar.alrashed@gmail.com>

* lint fix

Signed-off-by: ammarar <ammar.alrashed@gmail.com>

Signed-off-by: ammarar <ammar.alrashed@gmail.com>
adchia pushed a commit that referenced this pull request Sep 30, 2022
@feast-ci-bot
chore(release): release 0.25.1
3102b44 
## [0.25.1](v0.25.0...v0.25.1) (2022-09-30)

### Bug Fixes

* Add `X-Trino-Extra-Credential` header and remove user override ([#3246](#3246)) ([f38506c](f38506c))
* Add postgres to the feature server Dockerfile to fix helm chart flow ([#3261](#3261)) ([a2cb995](a2cb995))
* Add stream feature view in the Web UI ([#3257](#3257)) ([47d4c93](47d4c93))
* Build dockerfile correctly ([#3239](#3239)) ([a2dc0d0](a2dc0d0))
* Configuration to stop coercion of tz for entity_df ([#3255](#3255)) ([fdc8d67](fdc8d67))
* Enable users to upgrade a batch source into a push source ([#3213](#3213)) ([8f2fb58](8f2fb58))
* Return 422 on bad push source name ([#3214](#3214)) ([8abbcd9](8abbcd9))
* Stream feature view not shown in the UI ([#3251](#3251)) ([55e28e2](55e28e2))
* Update snowflake materialization messages ([#3230](#3230)) ([a63d440](a63d440))
* Use configured user in env var instead of "user" for Trino ([#3254](#3254)) ([e7ed3d5](e7ed3d5))
hao-affirm pushed a commit to Affirm/feast that referenced this pull request Oct 2, 2022
@feast-ci-bot @hao-affirm
chore(release): release 0.25.1
284ea97 
## [0.25.1](feast-dev/feast@v0.25.0...v0.25.1) (2022-09-30)

### Bug Fixes

* Add `X-Trino-Extra-Credential` header and remove user override ([feast-dev#3246](feast-dev#3246)) ([f38506c](feast-dev@f38506c))
* Add postgres to the feature server Dockerfile to fix helm chart flow ([feast-dev#3261](feast-dev#3261)) ([a2cb995](feast-dev@a2cb995))
* Add stream feature view in the Web UI ([feast-dev#3257](feast-dev#3257)) ([47d4c93](feast-dev@47d4c93))
* Build dockerfile correctly ([feast-dev#3239](feast-dev#3239)) ([a2dc0d0](feast-dev@a2dc0d0))
* Configuration to stop coercion of tz for entity_df ([feast-dev#3255](feast-dev#3255)) ([fdc8d67](feast-dev@fdc8d67))
* Enable users to upgrade a batch source into a push source ([feast-dev#3213](feast-dev#3213)) ([8f2fb58](feast-dev@8f2fb58))
* Return 422 on bad push source name ([feast-dev#3214](feast-dev#3214)) ([8abbcd9](feast-dev@8abbcd9))
* Stream feature view not shown in the UI ([feast-dev#3251](feast-dev#3251)) ([55e28e2](feast-dev@55e28e2))
* Update snowflake materialization messages ([feast-dev#3230](feast-dev#3230)) ([a63d440](feast-dev@a63d440))
* Use configured user in env var instead of "user" for Trino ([feast-dev#3254](feast-dev#3254)) ([e7ed3d5](feast-dev@e7ed3d5))
kevjumba pushed a commit that referenced this pull request Oct 6, 2022
@feast-ci-bot
chore(release): release 0.26.0
7417dd3 
# [0.26.0](v0.25.0...v0.26.0) (2022-10-06)

### Bug Fixes

* Add `X-Trino-Extra-Credential` header and remove user override ([#3246](#3246)) ([164e666](164e666))
* Add postgres to the feature server Dockerfile to fix helm chart flow ([#3261](#3261)) ([6f6cbb7](6f6cbb7))
* Add stream feature view in the Web UI ([#3257](#3257)) ([1f70b3a](1f70b3a))
* Build dockerfile correctly ([#3239](#3239)) ([a2dc0d0](a2dc0d0))
* Configuration to stop coercion of tz for entity_df ([#3255](#3255)) ([97b7ab9](97b7ab9))
* Enable users to upgrade a batch source into a push source ([#3213](#3213)) ([1b312fb](1b312fb))
* Fix docker image for feature-server ([#3272](#3272)) ([eff01d1](eff01d1))
* Fix Feast UI release process to update the feast-ui package  ([#3267](#3267)) ([a9d48d0](a9d48d0))
* Return 422 on bad push source name ([#3214](#3214)) ([b851e01](b851e01))
* Stream feature view meta undefined created_timestamp issue ([#3266](#3266)) ([12e1a8f](12e1a8f))
* Stream feature view not shown in the UI ([#3251](#3251)) ([e713dda](e713dda))
* Udf in stream feature view UI shows pickled data ([#3268](#3268)) ([0728117](0728117))
* Update snowflake materialization messages ([#3230](#3230)) ([a63d440](a63d440))
* Updated quickstart notebook to patch an incorrect reference to an outdated featureview name ([#3271](#3271)) ([b9b9c54](b9b9c54))
* Use configured user in env var instead of "user" for Trino ([#3254](#3254)) ([532d8a1](532d8a1))

### Features

* Add mysql as online store ([#3190](#3190)) ([cb8db84](cb8db84))
* Add possibility to define feature_store.yaml path with env variable ([#3231](#3231)) ([95fdb19](95fdb19))
* Add request_timeout setting for cassandra online store adapter ([#3256](#3256)) ([da20757](da20757))
* Add tag description in Field in the Feast UI ([#3258](#3258)) ([086f279](086f279))
* Adding billing_project_id in BigQueryOfflineStoreConfig ([#3253](#3253)) ([f80f05f](f80f05f))
* BigTable online store ([#3140](#3140)) ([6bc91c2](6bc91c2)), closes [/github.com/spulec/moto/blob/master/CHANGELOG.md#400](https://github.com//github.com/spulec/moto/blob/master/CHANGELOG.md/issues/400)
* Filter subset features in postgres [#3174](#3174) ([#3203](#3203)) ([b48d36b](b48d36b))
franciscojavierarceo pushed a commit to franciscojavierarceo/feast that referenced this pull request Oct 18, 2022
@feast-ci-bot @franciscojavierarceo
chore(release): release 0.26.0
e2fba60 
# [0.26.0](feast-dev/feast@v0.25.0...v0.26.0) (2022-10-06)

### Bug Fixes

* Add `X-Trino-Extra-Credential` header and remove user override ([feast-dev#3246](feast-dev#3246)) ([164e666](feast-dev@164e666))
* Add postgres to the feature server Dockerfile to fix helm chart flow ([feast-dev#3261](feast-dev#3261)) ([6f6cbb7](feast-dev@6f6cbb7))
* Add stream feature view in the Web UI ([feast-dev#3257](feast-dev#3257)) ([1f70b3a](feast-dev@1f70b3a))
* Build dockerfile correctly ([feast-dev#3239](feast-dev#3239)) ([a2dc0d0](feast-dev@a2dc0d0))
* Configuration to stop coercion of tz for entity_df ([feast-dev#3255](feast-dev#3255)) ([97b7ab9](feast-dev@97b7ab9))
* Enable users to upgrade a batch source into a push source ([feast-dev#3213](feast-dev#3213)) ([1b312fb](feast-dev@1b312fb))
* Fix docker image for feature-server ([feast-dev#3272](feast-dev#3272)) ([eff01d1](feast-dev@eff01d1))
* Fix Feast UI release process to update the feast-ui package  ([feast-dev#3267](feast-dev#3267)) ([a9d48d0](feast-dev@a9d48d0))
* Return 422 on bad push source name ([feast-dev#3214](feast-dev#3214)) ([b851e01](feast-dev@b851e01))
* Stream feature view meta undefined created_timestamp issue ([feast-dev#3266](feast-dev#3266)) ([12e1a8f](feast-dev@12e1a8f))
* Stream feature view not shown in the UI ([feast-dev#3251](feast-dev#3251)) ([e713dda](feast-dev@e713dda))
* Udf in stream feature view UI shows pickled data ([feast-dev#3268](feast-dev#3268)) ([0728117](feast-dev@0728117))
* Update snowflake materialization messages ([feast-dev#3230](feast-dev#3230)) ([a63d440](feast-dev@a63d440))
* Updated quickstart notebook to patch an incorrect reference to an outdated featureview name ([feast-dev#3271](feast-dev#3271)) ([b9b9c54](feast-dev@b9b9c54))
* Use configured user in env var instead of "user" for Trino ([feast-dev#3254](feast-dev#3254)) ([532d8a1](feast-dev@532d8a1))

### Features

* Add mysql as online store ([feast-dev#3190](feast-dev#3190)) ([cb8db84](feast-dev@cb8db84))
* Add possibility to define feature_store.yaml path with env variable ([feast-dev#3231](feast-dev#3231)) ([95fdb19](feast-dev@95fdb19))
* Add request_timeout setting for cassandra online store adapter ([feast-dev#3256](feast-dev#3256)) ([da20757](feast-dev@da20757))
* Add tag description in Field in the Feast UI ([feast-dev#3258](feast-dev#3258)) ([086f279](feast-dev@086f279))
* Adding billing_project_id in BigQueryOfflineStoreConfig ([feast-dev#3253](feast-dev#3253)) ([f80f05f](feast-dev@f80f05f))
* BigTable online store ([feast-dev#3140](feast-dev#3140)) ([6bc91c2](feast-dev@6bc91c2)), closes [/github.com/spulec/moto/blob/master/CHANGELOG.md#400](https://github.com//github.com/spulec/moto/blob/master/CHANGELOG.md/issues/400)
* Filter subset features in postgres [feast-dev#3174](feast-dev#3174) ([feast-dev#3203](feast-dev#3203)) ([b48d36b](feast-dev@b48d36b))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixwang9817 felixwang9817 felixwang9817 approved these changes

Assignees

@felixwang9817 felixwang9817

Labels
approved lgtm size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ammarar @felixwang9817 @codecov-commenter @feast-ci-bot